Fixed member joinedAt being overwritten for the Slack and Twitter integrations#729
Merged
joanreyero merged 5 commits intomainfrom Apr 6, 2023
Merged
Fixed member joinedAt being overwritten for the Slack and Twitter integrations#729joanreyero merged 5 commits intomainfrom
joanreyero merged 5 commits intomainfrom
Conversation
added 2 commits
April 6, 2023 11:07
themarolt
approved these changes
Apr 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
When we onboarded we set the follow timestamp to 1970, and the member’s joinedAt as well. So far so good.
But when we onboard, we upsert that same activity with timestamp now(). The upsert for activities was working fine. However, when it was calling the upsert for members, it was sending the timestamp now() as joinedAt , when it should have been sending the timestamp of the existing activity.
Checklist ✅
Feature,Enhancement, orBug.frontend/.env.dist.local,frontend/.env.dist.composed.backend/.env.dist.local,backend/.env.dist.composed.